content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2144733005: [WIP] cc: Plumb SurfaceId from clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2144733005: [WIP] cc: Plumb SurfaceId from clients Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ensure only SurfaceFactoy and tests can update hierarchy Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 0dc3ef091766a161c2af2c3a9f3e4e66f8a37342..fc76b48c1cb7ba68cd857a37e0d28a298eb498d8 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1287,8 +1287,10 @@ bool RenderWidgetHostViewMac::HasAcceleratedSurface(

return false;

}

-void RenderWidgetHostViewMac::OnSwapCompositorFrame(uint32_t output_surface_id,

- cc::CompositorFrame frame) {

+void RenderWidgetHostViewMac::OnSwapCompositorFrame(

+ uint32_t output_surface_id,

+ const cc::SurfaceId& surface_id,

+ cc::CompositorFrame frame) {

TRACE_EVENT0("browser", "RenderWidgetHostViewMac::OnSwapCompositorFrame");

last_scroll_offset_ = frame.metadata.root_scroll_offset;