Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2143483002: Use the single char overload of append() when possible. (Closed)

Created:
4 years, 5 months ago by esprehn
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
aboxhall+watch_chromium.org, aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, eric.carlson_apple.com, Eric Willigers, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, Nate Chapin, je_julie, jfernandez, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, nektarios, nektar+watch_chromium.org, pfeldman+blink_chromium.org, Manuel Rego, rjwright, rwlbuis, sergeyv+blink_chromium.org, shans, svillar, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the single char overload of append() when possible. We should use StringBuilder::append(LChar) or String::append(LChar) when possible since it produces smaller code and is faster. I also switched some code that was calling String::append() repeatedly to use StringBuilder instead to avoid the repeated copies. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/0ea8294b494133a91a8d6c9dbeae031945143528 Cr-Commit-Position: refs/heads/master@{#404964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -48 lines) Patch
M third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGridAutoRepeatValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSNamespaceRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPageRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (17 generated)
esprehn
4 years, 5 months ago (2016-07-12 00:40:01 UTC) #8
haraken
LGTM
4 years, 5 months ago (2016-07-12 00:58:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483002/1
4 years, 5 months ago (2016-07-12 01:20:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260560)
4 years, 5 months ago (2016-07-12 03:18:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483002/1
4 years, 5 months ago (2016-07-12 03:32:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260719)
4 years, 5 months ago (2016-07-12 06:43:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483002/1
4 years, 5 months ago (2016-07-12 19:12:24 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261323)
4 years, 5 months ago (2016-07-12 22:42:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483002/1
4 years, 5 months ago (2016-07-12 22:53:09 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191901)
4 years, 5 months ago (2016-07-13 01:08:11 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483002/1
4 years, 5 months ago (2016-07-13 01:54:36 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:31:14 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:32:43 UTC) #30
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ea8294b494133a91a8d6c9dbeae031945143528
Cr-Commit-Position: refs/heads/master@{#404964}

Powered by Google App Engine
This is Rietveld 408576698