third_party/WebKit/Source/modules/payments/PaymentAddress.cpp - Issue 2143483002: Use the single char overload of append() when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAddress.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentAddress.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp b/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp

index 10fc77910557bff1aa91ba5c75f2b07d0379a163..fea61124fe053db5ece1068b381675bf26e49f04 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp

@@ -4,6 +4,8 @@

#include "modules/payments/PaymentAddress.h"

+#include "wtf/text/StringBuilder.h"

namespace blink {

PaymentAddress::PaymentAddress(mojom::blink::PaymentAddressPtr address)

@@ -21,8 +23,11 @@ PaymentAddress::PaymentAddress(mojom::blink::PaymentAddressPtr address)

, m_phone(address->phone)

{

if (!m_languageCode.isEmpty() && !address->script_code.isEmpty()) {

- m_languageCode.append("-");

- m_languageCode.append(address->script_code);

+ StringBuilder builder;

+ builder.append(m_languageCode);

+ builder.append('-');

+ builder.append(address->script_code);

+ m_languageCode = builder.toString();

}