Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/parser/CSSParserToken.h" 5 #include "core/css/parser/CSSParserToken.h"
6 6
7 #include "core/css/CSSMarkup.h" 7 #include "core/css/CSSMarkup.h"
8 #include "core/css/CSSPrimitiveValue.h" 8 #include "core/css/CSSPrimitiveValue.h"
9 #include "core/css/parser/CSSPropertyParser.h" 9 #include "core/css/parser/CSSPropertyParser.h"
10 #include "wtf/HashMap.h" 10 #include "wtf/HashMap.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 builder.append('@'); 212 builder.append('@');
213 serializeIdentifier(value().toString(), builder); 213 serializeIdentifier(value().toString(), builder);
214 break; 214 break;
215 case HashToken: 215 case HashToken:
216 builder.append('#'); 216 builder.append('#');
217 serializeIdentifier(value().toString(), builder, (getHashTokenType() == HashTokenUnrestricted)); 217 serializeIdentifier(value().toString(), builder, (getHashTokenType() == HashTokenUnrestricted));
218 break; 218 break;
219 case UrlToken: 219 case UrlToken:
220 builder.append("url("); 220 builder.append("url(");
221 serializeIdentifier(value().toString(), builder); 221 serializeIdentifier(value().toString(), builder);
222 return builder.append(")"); 222 return builder.append(')');
223 case DelimiterToken: 223 case DelimiterToken:
224 if (delimiter() == '\\') 224 if (delimiter() == '\\')
225 return builder.append("\\\n"); 225 return builder.append("\\\n");
226 return builder.append(delimiter()); 226 return builder.append(delimiter());
227 case NumberToken: 227 case NumberToken:
228 // These won't properly preserve the NumericValueType flag 228 // These won't properly preserve the NumericValueType flag
229 return builder.appendNumber(numericValue()); 229 return builder.appendNumber(numericValue());
230 case PercentageToken: 230 case PercentageToken:
231 builder.appendNumber(numericValue()); 231 builder.appendNumber(numericValue());
232 return builder.append('%'); 232 return builder.append('%');
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 return value >= -std::numeric_limits<float>::max() 293 return value >= -std::numeric_limits<float>::max()
294 && value <= std::numeric_limits<float>::max(); 294 && value <= std::numeric_limits<float>::max();
295 } 295 }
296 296
297 bool CSSParserToken::isValidNumericValue() const 297 bool CSSParserToken::isValidNumericValue() const
298 { 298 {
299 return isValidNumericValue(numericValue()); 299 return isValidNumericValue(numericValue());
300 } 300 }
301 301
302 } // namespace blink 302 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySerializer.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698