Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 formatWebGLStatusString("DEVICE", info.deviceId ? String::format("0x%04x", i nfo.deviceId).utf8().data() : "0xffff", statusMessage); 527 formatWebGLStatusString("DEVICE", info.deviceId ? String::format("0x%04x", i nfo.deviceId).utf8().data() : "0xffff", statusMessage);
528 formatWebGLStatusString("GL_VENDOR", info.vendorInfo.utf8().data(), statusMe ssage); 528 formatWebGLStatusString("GL_VENDOR", info.vendorInfo.utf8().data(), statusMe ssage);
529 formatWebGLStatusString("GL_RENDERER", info.rendererInfo.utf8().data(), stat usMessage); 529 formatWebGLStatusString("GL_RENDERER", info.rendererInfo.utf8().data(), stat usMessage);
530 formatWebGLStatusString("GL_VERSION", info.driverVersion.utf8().data(), stat usMessage); 530 formatWebGLStatusString("GL_VERSION", info.driverVersion.utf8().data(), stat usMessage);
531 formatWebGLStatusString("Sandboxed", info.sandboxed ? "yes" : "no", statusMe ssage); 531 formatWebGLStatusString("Sandboxed", info.sandboxed ? "yes" : "no", statusMe ssage);
532 formatWebGLStatusString("Optimus", info.optimus ? "yes" : "no", statusMessag e); 532 formatWebGLStatusString("Optimus", info.optimus ? "yes" : "no", statusMessag e);
533 formatWebGLStatusString("AMD switchable", info.amdSwitchable ? "yes" : "no", statusMessage); 533 formatWebGLStatusString("AMD switchable", info.amdSwitchable ? "yes" : "no", statusMessage);
534 formatWebGLStatusString("Reset notification strategy", String::format("0x%04 x", info.resetNotificationStrategy).utf8().data(), statusMessage); 534 formatWebGLStatusString("Reset notification strategy", String::format("0x%04 x", info.resetNotificationStrategy).utf8().data(), statusMessage);
535 formatWebGLStatusString("GPU process crash count", String::number(info.proce ssCrashCount).utf8().data(), statusMessage); 535 formatWebGLStatusString("GPU process crash count", String::number(info.proce ssCrashCount).utf8().data(), statusMessage);
536 formatWebGLStatusString("ErrorMessage", info.errorMessage.utf8().data(), sta tusMessage); 536 formatWebGLStatusString("ErrorMessage", info.errorMessage.utf8().data(), sta tusMessage);
537 statusMessage.append("."); 537 statusMessage.append('.');
538 return statusMessage; 538 return statusMessage;
539 } 539 }
540 540
541 struct ContextProviderCreationInfo { 541 struct ContextProviderCreationInfo {
542 // Inputs. 542 // Inputs.
543 Platform::ContextAttributes contextAttributes; 543 Platform::ContextAttributes contextAttributes;
544 Platform::GraphicsInfo* glInfo; 544 Platform::GraphicsInfo* glInfo;
545 ScriptState* scriptState; 545 ScriptState* scriptState;
546 // Outputs. 546 // Outputs.
547 std::unique_ptr<WebGraphicsContext3DProvider> createdContextProvider; 547 std::unique_ptr<WebGraphicsContext3DProvider> createdContextProvider;
(...skipping 5935 matching lines...) Expand 10 before | Expand all | Expand 10 after
6483 contextGL()->PixelStorei(GL_UNPACK_ALIGNMENT, 1); 6483 contextGL()->PixelStorei(GL_UNPACK_ALIGNMENT, 1);
6484 } 6484 }
6485 6485
6486 void WebGLRenderingContextBase::restoreUnpackParameters() 6486 void WebGLRenderingContextBase::restoreUnpackParameters()
6487 { 6487 {
6488 if (m_unpackAlignment != 1) 6488 if (m_unpackAlignment != 1)
6489 contextGL()->PixelStorei(GL_UNPACK_ALIGNMENT, m_unpackAlignment); 6489 contextGL()->PixelStorei(GL_UNPACK_ALIGNMENT, m_unpackAlignment);
6490 } 6490 }
6491 6491
6492 } // namespace blink 6492 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698