third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp - Issue 2143483002: Use the single char overload of append() when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp ('k') | third_party/WebKit/Source/core/testing/DictionaryTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

index 0698b14a48429e08abe2f49bb592b22b2745647d..1fdc7f4497f84385b14bb552c52501f4bfd5316f 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

@@ -646,20 +646,20 @@ String canonicalCSSText(CSSRule* rule)

StringBuilder builder;

builder.append(styleRule->selectorText());

- builder.append("{");

+ builder.append('{');

for (unsigned i = 0; i < propertyNames.size(); ++i) {

String name = propertyNames.at(i);

- builder.append(" ");

+ builder.append(' ');

builder.append(name);

- builder.append(":");

+ builder.append(':');

builder.append(style->getPropertyValue(name));

if (!style->getPropertyPriority(name).isEmpty()) {

- builder.append(" ");

+ builder.append(' ');

builder.append(style->getPropertyPriority(name));

}

- builder.append(";");

+ builder.append(';');

}

- builder.append("}");

+ builder.append('}');

return builder.toString();

}