Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 builder.append("hasClients("); 611 builder.append("hasClients(");
612 builder.appendNumber(m_clients.size()); 612 builder.appendNumber(m_clients.size());
613 if (!m_clientsAwaitingCallback.isEmpty()) { 613 if (!m_clientsAwaitingCallback.isEmpty()) {
614 builder.append(", AwaitingCallback="); 614 builder.append(", AwaitingCallback=");
615 builder.appendNumber(m_clientsAwaitingCallback.size()); 615 builder.appendNumber(m_clientsAwaitingCallback.size());
616 } 616 }
617 if (!m_finishedClients.isEmpty()) { 617 if (!m_finishedClients.isEmpty()) {
618 builder.append(", Finished="); 618 builder.append(", Finished=");
619 builder.appendNumber(m_finishedClients.size()); 619 builder.appendNumber(m_finishedClients.size());
620 } 620 }
621 builder.append(")"); 621 builder.append(')');
622 } 622 }
623 if (m_loader) { 623 if (m_loader) {
624 if (!builder.isEmpty()) 624 if (!builder.isEmpty())
625 builder.append(' '); 625 builder.append(' ');
626 builder.append("m_loader"); 626 builder.append("m_loader");
627 } 627 }
628 if (m_preloadCount) { 628 if (m_preloadCount) {
629 if (!builder.isEmpty()) 629 if (!builder.isEmpty())
630 builder.append(' '); 630 builder.append(' ');
631 builder.append("m_preloadCount("); 631 builder.append("m_preloadCount(");
632 builder.appendNumber(m_preloadCount); 632 builder.appendNumber(m_preloadCount);
633 builder.append(")"); 633 builder.append(')');
634 } 634 }
635 if (memoryCache()->contains(this)) { 635 if (memoryCache()->contains(this)) {
636 if (!builder.isEmpty()) 636 if (!builder.isEmpty())
637 builder.append(' '); 637 builder.append(' ');
638 builder.append("in_memory_cache"); 638 builder.append("in_memory_cache");
639 } 639 }
640 return builder.toString(); 640 return builder.toString();
641 } 641 }
642 642
643 void Resource::didAddClient(ResourceClient* c) 643 void Resource::didAddClient(ResourceClient* c)
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
1128 case Resource::Media: 1128 case Resource::Media:
1129 return "Media"; 1129 return "Media";
1130 case Resource::Manifest: 1130 case Resource::Manifest:
1131 return "Manifest"; 1131 return "Manifest";
1132 } 1132 }
1133 ASSERT_NOT_REACHED(); 1133 ASSERT_NOT_REACHED();
1134 return "Unknown"; 1134 return "Unknown";
1135 } 1135 }
1136 1136
1137 } // namespace blink 1137 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698