Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

Issue 2143483002: Use the single char overload of append() when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 completeURL = element.document().completeURL(attribute.value()); 176 completeURL = element.document().completeURL(attribute.value());
177 break; 177 break;
178 } 178 }
179 } 179 }
180 180
181 if (completeURL.isNull() || !m_rewriteURLs.contains(completeURL)) 181 if (completeURL.isNull() || !m_rewriteURLs.contains(completeURL))
182 return false; 182 return false;
183 183
184 StringBuilder uriBuilder; 184 StringBuilder uriBuilder;
185 uriBuilder.append(m_rewriteFolder); 185 uriBuilder.append(m_rewriteFolder);
186 uriBuilder.append("/"); 186 uriBuilder.append('/');
187 uriBuilder.append(m_rewriteURLs.get(completeURL)); 187 uriBuilder.append(m_rewriteURLs.get(completeURL));
188 rewrittenLink = uriBuilder.toString(); 188 rewrittenLink = uriBuilder.toString();
189 return true; 189 return true;
190 } 190 }
191 191
192 FrameTestHelpers::WebViewHelper m_helper; 192 FrameTestHelpers::WebViewHelper m_helper;
193 WebString m_folder; 193 WebString m_folder;
194 KURL m_baseUrl; 194 KURL m_baseUrl;
195 Vector<SerializedResource> m_resources; 195 Vector<SerializedResource> m_resources;
196 HashMap<String, String> m_rewriteURLs; 196 HashMap<String, String> m_rewriteURLs;
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 EXPECT_EQ("saved from url=(0015)http://foo.com/", FrameSerializer::markOfThe WebDeclaration(KURL(ParsedURLString, "http://foo.com"))); 525 EXPECT_EQ("saved from url=(0015)http://foo.com/", FrameSerializer::markOfThe WebDeclaration(KURL(ParsedURLString, "http://foo.com")));
526 EXPECT_EQ("saved from url=(0015)http://f-o.com/", FrameSerializer::markOfThe WebDeclaration(KURL(ParsedURLString, "http://f-o.com"))); 526 EXPECT_EQ("saved from url=(0015)http://f-o.com/", FrameSerializer::markOfThe WebDeclaration(KURL(ParsedURLString, "http://f-o.com")));
527 EXPECT_EQ("saved from url=(0019)http://foo.com-%2D/", FrameSerializer::markO fTheWebDeclaration(KURL(ParsedURLString, "http://foo.com--"))); 527 EXPECT_EQ("saved from url=(0019)http://foo.com-%2D/", FrameSerializer::markO fTheWebDeclaration(KURL(ParsedURLString, "http://foo.com--")));
528 EXPECT_EQ("saved from url=(0024)http://f-%2D.com-%2D%3E/", FrameSerializer:: markOfTheWebDeclaration(KURL(ParsedURLString, "http://f--.com-->"))); 528 EXPECT_EQ("saved from url=(0024)http://f-%2D.com-%2D%3E/", FrameSerializer:: markOfTheWebDeclaration(KURL(ParsedURLString, "http://f--.com-->")));
529 EXPECT_EQ("saved from url=(0020)http://foo.com/?-%2D", FrameSerializer::mark OfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com?--"))); 529 EXPECT_EQ("saved from url=(0020)http://foo.com/?-%2D", FrameSerializer::mark OfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com?--")));
530 EXPECT_EQ("saved from url=(0020)http://foo.com/#-%2D", FrameSerializer::mark OfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#--"))); 530 EXPECT_EQ("saved from url=(0020)http://foo.com/#-%2D", FrameSerializer::mark OfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#--")));
531 EXPECT_EQ("saved from url=(0026)http://foo.com/#bar-%2Dbaz", FrameSerializer ::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#bar--baz"))); 531 EXPECT_EQ("saved from url=(0026)http://foo.com/#bar-%2Dbaz", FrameSerializer ::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#bar--baz")));
532 } 532 }
533 533
534 } // namespace blink 534 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698