Add Texture2D and Sampler GrSLTypes

Add Texture2D and Sampler GrSLTypes

These two new types are in support of Vulkan and the ability to send
separate texture and sampler uniforms to the shader. They don't really fit
well in the current system, since the current system ties together to idea
of intended use and how to emit shader code into the same GrSLType enum.

In vulkan, I want the GrGLSLSampler object to be used as a Sampler2D, but
when appending its declaration it will emit a Texture2D and sampler object.

Our query for GrSLTypeIsSamplerType refers more to the combination of texture
and sampler and not just the sampler part. The GrSLTypeIs2DTextureType query
is for is a a SamplerType that uses Texture2Ds. My new types don't really fit
into either these categories as they are just half of the whole.

In some refactoring down the road (possibly connected with SkSL), I suggest we
split apart the concept of how we intend to use a GrGLSLSampler (Sampler2D, SamplerBuffer,
etc.), from how we actually add it to the code (sampler, texture2D, sampler2D, etc.).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143143002

Committed: https://skia.googlesource.com/skia/+/990dbc88796f656418bcc4c196df30ed9bef6345

[egdaniel, 2016-07-12 19:09:53]

Description was changed from

==========
Add Texture2D and Sampler GrSLTypes

These two new types are in support of Vulkan and the ability to send
separate texture and sampler uniforms to the shader. They don't really fit
well in the current system, since the current system ties together to idea
of intended use and how to emit shader code into the same GrSLType enum.

In vulkan, I want the GrGLSLSampler object to be used as a Sampler2D, but
when appending its declaration it will emit a Texture2D and sampler object.

Our query for GrSLTypeIsSamplerType refers more to the combination of texture
and sampler and not just the sampler part. The GrSLTypeIs2DTextureType query
is for is a a SamplerType that uses Texture2Ds. My new types don't really fit
into either these categories as they are just half of the whole.

In some refactoring down the road (possibly connected with SkSL), I suggest we
split apart the concept of how we intend to use a GrGLSLSampler (Sampler2D,
SamplerBuffer,
etc.), from how we actually add it to the code (sampler, texture2D, sampler2D,
etc.).

BUG=skia:
==========

to

==========
Add Texture2D and Sampler GrSLTypes

These two new types are in support of Vulkan and the ability to send
separate texture and sampler uniforms to the shader. They don't really fit
well in the current system, since the current system ties together to idea
of intended use and how to emit shader code into the same GrSLType enum.

In vulkan, I want the GrGLSLSampler object to be used as a Sampler2D, but
when appending its declaration it will emit a Texture2D and sampler object.

Our query for GrSLTypeIsSamplerType refers more to the combination of texture
and sampler and not just the sampler part. The GrSLTypeIs2DTextureType query
is for is a a SamplerType that uses Texture2Ds. My new types don't really fit
into either these categories as they are just half of the whole.

In some refactoring down the road (possibly connected with SkSL), I suggest we
split apart the concept of how we intend to use a GrGLSLSampler (Sampler2D,
SamplerBuffer,
etc.), from how we actually add it to the code (sampler, texture2D, sampler2D,
etc.).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143143002
==========

[egdaniel, 2016-07-12 19:10:53]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, ethannicholas@google.com, jvanverth@google.com

[bsalomon, 2016-07-12 19:47:56]

https://codereview.chromium.org/2143143002/diff/1/include/gpu/GrTypesPriv.h
File include/gpu/GrTypesPriv.h (right):

https://codereview.chromium.org/2143143002/diff/1/include/gpu/GrTypesPriv.h#n...
include/gpu/GrTypesPriv.h:29: kSamplerExternal_GrSLType,
I think with the addition of kSampler_GrSLType these guys are due for a refresh
to make it clear that they are combined texture/samplers. kTexture2DSampler,
kTextureExternalSampler, kTextureBufferSampler?

[egdaniel, 2016-07-12 20:34:11]

https://codereview.chromium.org/2143143002/diff/1/include/gpu/GrTypesPriv.h
File include/gpu/GrTypesPriv.h (right):

https://codereview.chromium.org/2143143002/diff/1/include/gpu/GrTypesPriv.h#n...
include/gpu/GrTypesPriv.h:29: kSamplerExternal_GrSLType,
On 2016/07/12 19:47:56, bsalomon wrote:
> I think with the addition of kSampler_GrSLType these guys are due for a
refresh
> to make it clear that they are combined texture/samplers. kTexture2DSampler,
> kTextureExternalSampler, kTextureBufferSampler?

works for me. I'll do that change.

[egdaniel, 2016-07-12 20:34:52]

https://codereview.chromium.org/2143143002/diff/1/include/gpu/GrTypesPriv.h
File include/gpu/GrTypesPriv.h (right):

https://codereview.chromium.org/2143143002/diff/1/include/gpu/GrTypesPriv.h#n...
include/gpu/GrTypesPriv.h:29: kSamplerExternal_GrSLType,
On 2016/07/12 20:34:11, egdaniel wrote:
> On 2016/07/12 19:47:56, bsalomon wrote:
> > I think with the addition of kSampler_GrSLType these guys are due for a
> refresh
> > to make it clear that they are combined texture/samplers. kTexture2DSampler,
> > kTextureExternalSampler, kTextureBufferSampler?
> 
> works for me. I'll do that change.

Done.

[egdaniel, 2016-07-13 20:27:20]

ping

[bsalomon, 2016-07-13 20:33:15]

lgtm

[egdaniel, 2016-07-13 20:35:30]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-13 20:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:09:32]

Description was changed from

==========
Add Texture2D and Sampler GrSLTypes

These two new types are in support of Vulkan and the ability to send
separate texture and sampler uniforms to the shader. They don't really fit
well in the current system, since the current system ties together to idea
of intended use and how to emit shader code into the same GrSLType enum.

In vulkan, I want the GrGLSLSampler object to be used as a Sampler2D, but
when appending its declaration it will emit a Texture2D and sampler object.

Our query for GrSLTypeIsSamplerType refers more to the combination of texture
and sampler and not just the sampler part. The GrSLTypeIs2DTextureType query
is for is a a SamplerType that uses Texture2Ds. My new types don't really fit
into either these categories as they are just half of the whole.

In some refactoring down the road (possibly connected with SkSL), I suggest we
split apart the concept of how we intend to use a GrGLSLSampler (Sampler2D,
SamplerBuffer,
etc.), from how we actually add it to the code (sampler, texture2D, sampler2D,
etc.).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143143002
==========

to

==========
Add Texture2D and Sampler GrSLTypes

These two new types are in support of Vulkan and the ability to send
separate texture and sampler uniforms to the shader. They don't really fit
well in the current system, since the current system ties together to idea
of intended use and how to emit shader code into the same GrSLType enum.

In vulkan, I want the GrGLSLSampler object to be used as a Sampler2D, but
when appending its declaration it will emit a Texture2D and sampler object.

Our query for GrSLTypeIsSamplerType refers more to the combination of texture
and sampler and not just the sampler part. The GrSLTypeIs2DTextureType query
is for is a a SamplerType that uses Texture2Ds. My new types don't really fit
into either these categories as they are just half of the whole.

In some refactoring down the road (possibly connected with SkSL), I suggest we
split apart the concept of how we intend to use a GrGLSLSampler (Sampler2D,
SamplerBuffer,
etc.), from how we actually add it to the code (sampler, texture2D, sampler2D,
etc.).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143143002

Committed:
https://skia.googlesource.com/skia/+/990dbc88796f656418bcc4c196df30ed9bef6345
==========

[commit-bot: I haz the power, 2016-07-13 21:09:33]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/990dbc88796f656418bcc4c196df30ed9bef6345