[DevTools] Report console API calls through Runtime.

[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the message (with a string representation of the first argument) via Console.messageAdded. This makes the change backwards-compatible.

BUG=613882
Committed: https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799
Cr-Commit-Position: refs/heads/master@{#405679}

[dgozman, 2016-07-13 00:37:25]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, pfeldman@chromium.org

[dgozman, 2016-07-13 00:37:26]

Take a look please.

[pfeldman, 2016-07-13 00:43:51]

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:334: "name":
"consoleAPICall",
consoleAPICalled

[pfeldman, 2016-07-13 00:48:43]

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (left):

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:1042: const
String16 defaultMessage = "Uncaught (in promise)";
Why do you need it in both places?

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:341: { "name":
"stack", "$ref": "StackTrace", "optional": true, "description": "Stack trace
captured when the call was made." }
stackTrace

[kozy, 2016-07-13 18:26:39]

lgtm % nits

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html
(right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html:110:
var message = payload.params.callArguments[0].value;
Please rename callArguments into args.

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:493: Count:
"count",
Why count is here?

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
(right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:340:
frontend->consoleAPICall(m_timestamp, consoleAPITypeValue(m_type),
std::move(arguments), m_contextId);
Can we replace it with smthg like:
frontend->consoleAPICall(m_timestamp, consoleAPITypeValue(m_type), s
     td::move(arguments), m_contextId, m_stackTrace ?
m_stackTrace->buildInspectorObject() : nullptr) ?

[kozy, 2016-07-13 18:48:49]

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
(right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:42:
virtual void consoleAPIMessage(int contextGroupId, MessageLevel, const String16&
message, const String16& url, unsigned lineNumber, unsigned columnNumber,
V8StackTrace*) = 0;
Please replace this method in V8Inspector.h

[dgozman, 2016-07-13 21:08:08]

PTAL

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (left):

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:1042: const
String16 defaultMessage = "Uncaught (in promise)";
On 2016/07/13 00:48:43, pfeldman wrote:
> Why do you need it in both places?

Done.

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:334: "name":
"consoleAPICall",
On 2016/07/13 00:43:50, pfeldman wrote:
> consoleAPICalled

Done.

https://codereview.chromium.org/2139543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:341: { "name":
"stack", "$ref": "StackTrace", "optional": true, "description": "Stack trace
captured when the call was made." }
On 2016/07/13 00:48:43, pfeldman wrote:
> stackTrace

Done.

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html
(right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html:110:
var message = payload.params.callArguments[0].value;
On 2016/07/13 18:26:39, kozyatinskiy wrote:
> Please rename callArguments into args.

Done.

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:493: Count:
"count",
On 2016/07/13 18:26:39, kozyatinskiy wrote:
> Why count is here?

Removed.

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
(right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:340:
frontend->consoleAPICall(m_timestamp, consoleAPITypeValue(m_type),
std::move(arguments), m_contextId);
On 2016/07/13 18:26:39, kozyatinskiy wrote:
> Can we replace it with smthg like:
> frontend->consoleAPICall(m_timestamp, consoleAPITypeValue(m_type), s
>      td::move(arguments), m_contextId, m_stackTrace ?
> m_stackTrace->buildInspectorObject() : nullptr) ?

Done.

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
(right):

https://codereview.chromium.org/2139543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:42:
virtual void consoleAPIMessage(int contextGroupId, MessageLevel, const String16&
message, const String16& url, unsigned lineNumber, unsigned columnNumber,
V8StackTrace*) = 0;
On 2016/07/13 18:48:49, kozyatinskiy wrote:
> Please replace this method in V8Inspector.h

Done.

[pfeldman, 2016-07-13 21:19:46]

lgtm

[dgozman, 2016-07-13 21:22:47]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-13 21:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2139543002/#ps60001
(title: "fixed all comments")

[commit-bot: I haz the power, 2016-07-13 21:23:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:44:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:44:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-07-13 21:50:33]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-13 21:50:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2139543002/#ps80001
(title: "fixed one more test")

[commit-bot: I haz the power, 2016-07-13 21:51:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:20:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-07-14 21:35:37]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 21:36:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 22:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 22:59:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-07-15 00:07:59]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-15 00:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2139543002/#ps100001
(title: "send a copy of console api messages to Console domain")

[commit-bot: I haz the power, 2016-07-15 00:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 00:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:13:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-07-15 00:25:21]

Description was changed from

==========
[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown.

BUG=613882
==========

to

==========
[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the
message (with a string representation of the first argument) via
Console.messageAdded. This makes the change backwards-compatible.

BUG=613882
==========

[dgozman, 2016-07-15 00:51:29]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-15 00:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2139543002/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-15 00:52:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 02:23:56]

Description was changed from

==========
[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the
message (with a string representation of the first argument) via
Console.messageAdded. This makes the change backwards-compatible.

BUG=613882
==========

to

==========
[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the
message (with a string representation of the first argument) via
Console.messageAdded. This makes the change backwards-compatible.

BUG=613882
==========

[commit-bot: I haz the power, 2016-07-15 02:23:57]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-15 02:24:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 02:25:35]

Description was changed from

==========
[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the
message (with a string representation of the first argument) via
Console.messageAdded. This makes the change backwards-compatible.

BUG=613882
==========

to

==========
[DevTools] Report console API calls through Runtime.

Follow the scheme of Runtime.exceptionThrown, but also send a copy of the
message (with a string representation of the first argument) via
Console.messageAdded. This makes the change backwards-compatible.

BUG=613882

Committed: https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799
Cr-Commit-Position: refs/heads/master@{#405679}
==========

[commit-bot: I haz the power, 2016-07-15 02:25:37]

Patchset 7 (id:??) landed as
https://crrev.com/fb90bf24d217da0937226ac058bae3f2a0d8e799
Cr-Commit-Position: refs/heads/master@{#405679}