third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

index 74eaf08e2e4aac30b8e287a18e0bef4f7464e1e3..ac15e5134244d41077afd0356b898573cc69ee0a 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

@@ -88,14 +88,14 @@ void V8ConsoleAgentImpl::reportAllMessages()

m_frontend.flush();

}

for (const auto& message : storage->messages()) {

- if (message->origin() == V8MessageOrigin::kConsole)

+ if (message->origin() == V8MessageOrigin::kExternalConsole || message->origin() == V8MessageOrigin::kConsole)

reportMessage(message.get(), false);

}

void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generatePreview)

{

- DCHECK_EQ(V8MessageOrigin::kConsole, message->origin());

+ DCHECK(message->origin() == V8MessageOrigin::kExternalConsole || message->origin() == V8MessageOrigin::kConsole);

message->reportToFrontend(&m_frontend, m_session, generatePreview);

m_frontend.flush();

}