content/renderer/render_view_browsertest.cc - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 91080b116cf0a9afaf03a9dea66c5477915b56d5..572fedd2dd21ba5db4e9533a548f1060c908c264 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -2435,8 +2435,8 @@ TEST_F(DevToolsAgentTest, RuntimeEnableForcesContextsAfterNavigation) {

TEST_F(DevToolsAgentTest, RuntimeEvaluateRunMicrotasks) {

LoadHTML("<body>page</body>");

Attach();

- DispatchDevToolsMessage("Console.enable",

- "{\"id\":1,\"method\":\"Console.enable\"}");

+ DispatchDevToolsMessage("Runtime.enable",

+ "{\"id\":1,\"method\":\"Runtime.enable\"}");

DispatchDevToolsMessage("Runtime.evaluate",

"{\"id\":2,"

"\"method\":\"Runtime.evaluate\","

@@ -2445,14 +2445,14 @@ TEST_F(DevToolsAgentTest, RuntimeEvaluateRunMicrotasks) {

"() => console.log(42));\""

"}"

"}");

- EXPECT_EQ(1, CountNotifications("Console.messageAdded"));

+ EXPECT_EQ(1, CountNotifications("Runtime.consoleAPICalled"));

}

TEST_F(DevToolsAgentTest, RuntimeCallFunctionOnRunMicrotasks) {