third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-deprecated-methods-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column.html b/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html

similarity index 75%

rename from third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column.html

rename to third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html

index 53bef3dc648d18262b4669e4b157e6d9e72f5401..9bc10e359a8c8e65e649ba6631a91f0f16842354 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-line-and-column.html

@@ -5,7 +5,7 @@

function test()

{

- InspectorTest.sendCommand("Console.enable", {});

+ InspectorTest.sendCommand("Runtime.enable", {});

addConsoleMessagePromise("console.log(239)")

.then(dumpMessage)

@@ -17,18 +17,18 @@ function test()

{

var cb;

var p = new Promise((resolver) => cb = resolver);

- InspectorTest.eventHandler["Console.messageAdded"] = (messageObject) => cb(messageObject);

+ InspectorTest.eventHandler["Runtime.consoleAPICalled"] = (messageObject) => cb(messageObject);

InspectorTest.sendCommand("Runtime.evaluate", { expression: expression });

return p;

}

function dumpMessage(messageObject)

{

- var msg = messageObject.params.message;

+ var msg = messageObject.params;

delete msg.executionContextId;

- delete msg.parameters;

+ delete msg.args;

delete msg.timestamp;

- for (var frame of msg.stack.callFrames)

+ for (var frame of msg.stackTrace.callFrames)

frame.scriptId = 0;

InspectorTest.logObject(msg);

}

@@ -39,3 +39,4 @@ function test()

</body>

</html>