Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
index eeea0aca59d882dfc01b588aa682999d1d98a63c..2e96bab7a7f72f9c79d28236717f588018c5688f 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
@@ -47,12 +47,14 @@ public:
~WorkerThreadDebugger() override;
static WorkerThreadDebugger* from(v8::Isolate*);
+ void reportConsoleMessage(ExecutionContext*, ConsoleMessage*) override;
int contextGroupId();
void contextCreated(v8::Local<v8::Context>);
void contextWillBeDestroyed(v8::Local<v8::Context>);
void exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation>);
void addConsoleMessage(ConsoleMessage*);
+ unsigned promiseRejected(v8::Local<v8::Context>, const String16& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation>);
// V8DebuggerClient implementation.
void runMessageLoopOnPause(int contextGroupId) override;
@@ -63,7 +65,7 @@ public:
v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;
v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;
- void messageAddedToConsole(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
+ void consoleAPIMessage(int contextGroupId, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
private:
WorkerThread* m_workerThread;

Powered by Google App Engine
This is Rietveld 408576698