Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
index 9ef345d905d4e988e05b79d296e2feaae9cb1839..9a33e0692866a804f6ad97f969364a1ec7b92aa2 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
@@ -67,6 +67,8 @@ public:
bool isWorker() override { return false; }
bool isPaused() const { return m_paused; }
void setClientMessageLoop(std::unique_ptr<ClientMessageLoop>);
+ void reportConsoleMessage(ExecutionContext*, ConsoleMessage*) override;
+
// TODO(dgozman): by making this method virtual, we can move many methods to ThreadDebugger and avoid some duplication. Should be careful about performance.
int contextGroupId(LocalFrame*);
void didClearContextsForFrame(LocalFrame*);
@@ -78,7 +80,6 @@ public:
void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;
- void messageAddedToConsole(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
private:
// V8DebuggerClient implementation.
@@ -88,6 +89,7 @@ private:
void unmuteWarningsAndDeprecations() override;
bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;
v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;
+ void consoleAPIMessage(int contextGroupId, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
std::unique_ptr<ClientMessageLoop> m_clientMessageLoop;
std::unique_ptr<InspectorTaskRunner> m_taskRunner;

Powered by Google App Engine
This is Rietveld 408576698