Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2136793002: Remove all unused variables. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all unused variables. Unused variables were found via pylint. There are a few types of circumstances where we have unused variables, so there are a few types of transformations: 1. variables that are simply unused, e.g. a = f() => <delete> 2. functions that return tuples but only some arguments are used, e.g. a, b = f() => a, _ = f() 3. functions that have side effects and also a return value, e.g. a = do_something() => do_something() 4. exception variables that are unused except Exception as e: => except Exception: Committed: https://crrev.com/69af2dee0ff02ff987b485e1ba297d94c8285427 Cr-Commit-Position: refs/heads/master@{#406887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -125 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 17 chunks +18 lines, -20 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py View 11 chunks +13 lines, -16 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py View 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 9 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/filereader.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/optparser_unittest.py View 3 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
qyearsley
4 years, 5 months ago (2016-07-11 16:41:45 UTC) #3
dcheng
non owner LGTM
4 years, 5 months ago (2016-07-12 03:22:38 UTC) #8
qyearsley
On 2016/07/12 at 03:22:38, dcheng wrote: > non owner LGTM Dirk, there are a few ...
4 years, 5 months ago (2016-07-20 20:43:56 UTC) #9
Dirk Pranke
On 2016/07/20 20:43:56, qyearsley wrote: > On 2016/07/12 at 03:22:38, dcheng wrote: > > non ...
4 years, 5 months ago (2016-07-20 23:40:16 UTC) #10
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-20 23:45:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136793002/1
4 years, 5 months ago (2016-07-21 16:05:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 17:30:55 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:33:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69af2dee0ff02ff987b485e1ba297d94c8285427
Cr-Commit-Position: refs/heads/master@{#406887}

Powered by Google App Engine
This is Rietveld 408576698