third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py - Issue 2136793002: Remove all unused variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 2136793002: Remove all unused variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

index 4dff0467fde74d7b7e330be062844859cba74a8f..d8a9e5ed1034088a0c36bb87c9ed1cb112bf0edd 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

@@ -223,7 +223,7 @@ class AndroidCommands(object):

def restart_adb(self):

pids = self.extract_pids('adbd')

if pids:

- output = self.run(['shell', 'kill', '-' + str(signal.SIGTERM)] + pids)

+ self.run(['shell', 'kill', '-' + str(signal.SIGTERM)] + pids)

self.run(['wait-for-device'])

def restart_as_root(self):

@@ -987,7 +987,7 @@ class ChromiumAndroidDriver(driver.Driver):

def _push_fonts(self, log_callback):

path_to_ahem_font = self._port._build_path('AHEM____.TTF')

self._push_file_if_needed(path_to_ahem_font, self._driver_details.device_fonts_directory() + 'AHEM____.TTF', log_callback)

- for (host_dirs, font_file, package) in HOST_FONT_FILES:

+ for (host_dirs, font_file, _) in HOST_FONT_FILES:

for host_dir in host_dirs:

host_font_path = host_dir + font_file

if self._port._check_file_exists(host_font_path, '', more_logging=False):