third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py - Issue 2136793002: Remove all unused variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

Issue 2136793002: Remove all unused variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

index c0192c8645fa82775203ef902f2fa48c0d82e707..235ca1090cff425945d310e3be69487421179f9c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

@@ -53,7 +53,7 @@ def get_options(args):

class TestUtilityFunctions(unittest.TestCase):

def test_print_options(self):

- options, args = get_options([])

+ options, _ = get_options([])

self.assertIsNotNone(options)

@@ -103,7 +103,6 @@ class Testprinter(unittest.TestCase):

options, args = option_parser.parse_args(args)

host = MockHost()

self._port = host.port_factory.get('test', options)

- nproc = 2

regular_output = StringIO.StringIO()

printer = printing.Printer(self._port, options, regular_output)

@@ -120,7 +119,7 @@ class Testprinter(unittest.TestCase):

def test_configure_and_cleanup(self):

# This test verifies that calling cleanup repeatedly and deleting

# the object is safe.

- printer, err = self.get_printer()

+ printer, _ = self.get_printer()

printer.cleanup()

printer = None