third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py - Issue 2136793002: Remove all unused variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

Issue 2136793002: Remove all unused variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

index f4fc025607cf1052a0956811207228baa79eb7c2..67d1996a4720817b0fab79e06613450e89016bc3 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py

@@ -82,7 +82,7 @@ class Bisector(object):

def verify_non_flaky(self):

print 'Verifying the failure is not flaky by running 10 times.'

count_failures = 0

- for i in range(0, 10):

+ for _ in range(0, 10):

if self.test_bucket_list_fails(self.buckets):

count_failures += 1

print 'Failed %d/10 times' % count_failures

@@ -161,7 +161,7 @@ def main(argv):

option_parser.add_option('--test-list', action='store',

help='file that list tests to bisect. The last test in the list is the expected failure.', metavar='FILE'),

option_parser.add_option('--debug', action='store_true', default=False, help='whether to use a debug build'),

- options, args = option_parser.parse_args(argv)

+ options, _ = option_parser.parse_args(argv)

tests = open(options.test_list).read().strip().split('\n')

bisector = Bisector(tests, is_debug=options.debug)