Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py

Issue 2136793002: Remove all unused variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
index ef40dc20699d0f508a6a5734c10d99eab41507a0..16e433a006a2bc7382b99139a42bf9e2d96e9fdb 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
@@ -162,7 +162,6 @@ class GlobalVariablesTest(unittest.TestCase):
def test_webkit_base_filter_rules(self):
base_filter_rules = _BASE_FILTER_RULES
- defaults = self.defaults()
already_seen = []
validate_filter_rules(base_filter_rules, self._all_categories())
# Also do some additional checks.
@@ -192,16 +191,13 @@ class GlobalVariablesTest(unittest.TestCase):
parser.parse(args=[])
def test_path_rules_specifier(self):
- all_categories = self._all_categories()
- for (sub_paths, path_rules) in PATH_RULES_SPECIFIER:
+ for _, path_rules in PATH_RULES_SPECIFIER:
validate_filter_rules(path_rules, self._all_categories())
config = FilterConfiguration(path_specific=PATH_RULES_SPECIFIER)
def assertCheck(path, category):
"""Assert that the given category should be checked."""
- message = ('Should check category "%s" for path "%s".'
- % (category, path))
self.assertTrue(config.should_check(category, path))
def assertNoCheck(path, category):
@@ -240,11 +236,11 @@ class CheckWebKitStyleFunctionTest(unittest.TestCase):
def test_check_webkit_style_configuration(self):
# Exercise the code path to make sure the function does not error out.
option_values = CommandOptionValues()
- configuration = check_webkit_style_configuration(option_values)
+ check_webkit_style_configuration(option_values)
def test_check_webkit_style_parser(self):
# Exercise the code path to make sure the function does not error out.
- parser = check_webkit_style_parser()
+ check_webkit_style_parser()
class CheckerDispatcherSkipTest(unittest.TestCase):

Powered by Google App Engine
This is Rietveld 408576698