third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py - Issue 2136793002: Remove all unused variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py

Issue 2136793002: Remove all unused variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py

index 0728d8abb06b4ead1c5341cfb3688dd06a96286c..49828d6786979e4cb3930bb725e32757385ce0b8 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py

@@ -60,7 +60,7 @@ class DumpReader(object):

return None

pid_to_minidump = dict()

- for root, dirs, files in self._host.filesystem.walk(self.crash_dumps_directory()):

+ for root, _, files in self._host.filesystem.walk(self.crash_dumps_directory()):

for dmp in [f for f in files if f.endswith(self._file_extension())]:

dmp_file = self._host.filesystem.join(root, dmp)

if self._host.filesystem.mtime(dmp_file) < start_time:

@@ -70,7 +70,7 @@ class DumpReader(object):

pid_to_minidump[pid] = dmp_file

result = dict()

- for test, process_name, pid in crashed_processes:

+ for test, _, pid in crashed_processes:

if str(pid) in pid_to_minidump:

stack = self._get_stack_from_dump(pid_to_minidump[str(pid)])

if stack: