third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py - Issue 2136793002: Remove all unused variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

Issue 2136793002: Remove all unused variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

index d9fc60994ab918c75b377ea2197ecb3a9dbe4ab5..ea57532a3800fe0599892be4b3d51b2f6f64b67e 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

@@ -158,7 +158,7 @@ class ServerBase(object):

for log_prefix in self._log_prefixes:

try:

self._remove_log_files(self._output_dir, log_prefix)

- except OSError as e:

+ except OSError:

_log.warning('Failed to remove old %s %s files' % (self._name, log_prefix))

def _spawn_process(self):

@@ -180,7 +180,6 @@ class ServerBase(object):

def _check_and_kill(self):

if self._executive.check_running_pid(self._pid):

_log.debug('pid %d is running, killing it' % self._pid)

- host = self._port_obj.host

self._executive.kill_process(self._pid)

return False

else: