NTP: Fix metrics recording race condition

NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is clicked. Before this CL, MostVisitedSites would get some info from its |current_suggestions_|, but those might have changed in the meantime. Now, all required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
Committed: https://crrev.com/87a0e130422e6427c19a69dd70f6511b95b0dac7
Cr-Commit-Position: refs/heads/master@{#405160}

[Marc Treib, 2016-07-08 11:48:45]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-07-08 11:48:46]

PTAL!

[Bernhard Bauer, 2016-07-08 12:37:46]

LGTM, but you could update the CL description to explain the race condition, so
a casual reader doesn't have to dig into the diff.

[Marc Treib, 2016-07-08 12:43:30]

Description was changed from

==========
NTP: Fix metrics recording race condition

BUG=612160
==========

to

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the mean time. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
==========

[Marc Treib, 2016-07-08 12:44:02]

Description was changed from

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the mean time. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
==========

to

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the meantime. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
==========

[Marc Treib, 2016-07-08 12:44:09]

On 2016/07/08 12:37:46, Bernhard Bauer wrote:
> LGTM, but you could update the CL description to explain the race condition,
so
> a casual reader doesn't have to dig into the diff.

Done, thanks!

[Marc Treib, 2016-07-13 14:56:42]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-07-13 14:56:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2136503002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-13 14:57:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:34:26]

Description was changed from

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the meantime. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
==========

to

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the meantime. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
==========

[commit-bot: I haz the power, 2016-07-13 15:34:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 15:34:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 15:36:08]

Description was changed from

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the meantime. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160
==========

to

==========
NTP: Fix metrics recording race condition

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is
clicked. Before this CL, MostVisitedSites would get some info from its
|current_suggestions_|, but those might have changed in the meantime. Now, all
required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160

Committed: https://crrev.com/87a0e130422e6427c19a69dd70f6511b95b0dac7
Cr-Commit-Position: refs/heads/master@{#405160}
==========

[commit-bot: I haz the power, 2016-07-13 15:36:09]

Patchset 3 (id:??) landed as
https://crrev.com/87a0e130422e6427c19a69dd70f6511b95b0dac7
Cr-Commit-Position: refs/heads/master@{#405160}