chrome/browser/android/ntp/most_visited_sites_bridge.cc - Issue 2136503002: NTP: Fix metrics recording race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/most_visited_sites_bridge.cc

Issue 2136503002: NTP: Fix metrics recording race condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_uma

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/ntp/most_visited_sites_bridge.cc

diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.cc b/chrome/browser/android/ntp/most_visited_sites_bridge.cc

index 6272acfe2502daf26c0ad416156cd210a94216bc..73e68b44e1e4b0e287e4be6df832b39fd3c658b9 100644

--- a/chrome/browser/android/ntp/most_visited_sites_bridge.cc

+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.cc

@@ -214,8 +214,9 @@ void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(

JNIEnv* env,

const JavaParamRef<jobject>& obj,

jint index,

- jint tile_type) {

- most_visited_.RecordOpenedMostVisitedItem(index, tile_type);

+ jint tile_type,

+ jint source) {

+ most_visited_.RecordOpenedMostVisitedItem(index, tile_type, source);

}

// static