components/ntp_tiles/most_visited_sites.h - Issue 2136503002: NTP: Fix metrics recording race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.h

Issue 2136503002: NTP: Fix metrics recording race condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_uma

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.h

diff --git a/components/ntp_tiles/most_visited_sites.h b/components/ntp_tiles/most_visited_sites.h

index a4912da9f931bfe8a030d60ac9454b58433415fd..0c52916a8af3750948b247d558ccfdc9d25d2801 100644

--- a/components/ntp_tiles/most_visited_sites.h

+++ b/components/ntp_tiles/most_visited_sites.h

@@ -172,7 +172,7 @@ class MostVisitedSites : public history::TopSitesObserver,

void AddOrRemoveBlacklistedUrl(const GURL& url, bool add_url);

void RecordTileTypeMetrics(const std::vector<int>& tile_types,

const std::vector<int>& sources);

- void RecordOpenedMostVisitedItem(int index, int tile_type);

+ void RecordOpenedMostVisitedItem(int index, int tile_type, int source);

// MostVisitedSitesSupervisor::Observer implementation.

void OnBlockedSitesChanged() override;