Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2126263002: Add NewTabPage.MostVisited and .SuggestionsImpression on Android (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_provider_id
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NewTabPage.MostVisited and .SuggestionsImpression on Android The same histograms already exist on desktop, see ntp_user_data_logger.cc BUG=625153 Committed: https://crrev.com/47e486826a2a7a8865e1fceb2e1494443625c954 Cr-Commit-Position: refs/heads/master@{#405142}

Patch Set 1 #

Patch Set 2 : unrelated cleanup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M components/ntp_tiles/most_visited_sites.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Marc Treib
PTAL!
4 years, 5 months ago (2016-07-07 15:19:11 UTC) #3
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-07 16:07:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126263002/40001
4 years, 5 months ago (2016-07-13 12:56:24 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 14:29:11 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 14:29:23 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 14:31:51 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47e486826a2a7a8865e1fceb2e1494443625c954
Cr-Commit-Position: refs/heads/master@{#405142}

Powered by Google App Engine
This is Rietveld 408576698