chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java - Issue 2136503002: NTP: Fix metrics recording race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

Issue 2136503002: NTP: Fix metrics recording race condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_uma

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

index 08d747b4eb4fdad553bd89085d85ecbf3d3c6bf3..86835092624397ae5ee099719ebca29a5b38a5be 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

@@ -120,8 +120,8 @@ public class MostVisitedSites {

* @param index The index of the item that was opened.

* @param tileType The visual type of the item. Valid values are listed in MostVisitedTileType.

- public void recordOpenedMostVisitedItem(int index, int tileType) {

- nativeRecordOpenedMostVisitedItem(mNativeMostVisitedSitesBridge, index, tileType);

+ public void recordOpenedMostVisitedItem(int index, int tileType, int source) {

+ nativeRecordOpenedMostVisitedItem(mNativeMostVisitedSitesBridge, index, tileType, source);

}

private native long nativeInit(Profile profile);

@@ -134,6 +134,5 @@ public class MostVisitedSites {

private native void nativeRecordTileTypeMetrics(long nativeMostVisitedSitesBridge,

int[] tileTypes, int[] sources);

private native void nativeRecordOpenedMostVisitedItem(

- long nativeMostVisitedSitesBridge, int index, int tileType);

+ long nativeMostVisitedSitesBridge, int index, int tileType, int source);

}