Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2131133003: Add NewTabPage.TileType and .TileTypeClicked on Android (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_race_condition
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NewTabPage.TileType and .TileTypeClicked on Android There already are versions of these split by tile source, but the accumulated totals weren't there. BUG=611341 Committed: https://crrev.com/7668db462821887491792b20435d9bab1d749da1 Cr-Commit-Position: refs/heads/master@{#405199}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/ntp_tiles/most_visited_sites.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Marc Treib
PTAL!
4 years, 5 months ago (2016-07-13 10:13:15 UTC) #2
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-13 11:27:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131133003/20001
4 years, 5 months ago (2016-07-13 16:05:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 17:00:04 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 17:00:08 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:01:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7668db462821887491792b20435d9bab1d749da1
Cr-Commit-Position: refs/heads/master@{#405199}

Powered by Google App Engine
This is Rietveld 408576698