chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2136503002: NTP: Fix metrics recording race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2136503002: NTP: Fix metrics recording race condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_uma

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index c89ba598058306553e030c25ed83ddbeae2bafc0..ba6e1ce99015ed7100e25ee53806984aa2a1a178 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -236,7 +236,8 @@ public class NewTabPage

item.getUrl(), NewTabPageUma.RAPPOR_ACTION_VISITED_SUGGESTED_TILE);

RecordHistogram.recordMediumTimesHistogram("NewTabPage.MostVisitedTime",

System.nanoTime() - mLastShownTimeNs, TimeUnit.NANOSECONDS);

- mMostVisitedSites.recordOpenedMostVisitedItem(item.getIndex(), item.getTileType());

+ mMostVisitedSites.recordOpenedMostVisitedItem(

+ item.getIndex(), item.getTileType(), item.getSource());

}

@Override

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java » ('j') | no next file with comments »