Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2133203002: [Extensions] Code cleanup (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Code cleanup Sprinkle in some const&s and explicit ctors in a few places that jumped out. BUG=None Committed: https://crrev.com/0a0942f1975a6c8dc8f345fa336f1facbc9d571e Cr-Commit-Position: refs/heads/master@{#404509}

Patch Set 1 : update #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M extensions/browser/api/execute_code_function.h View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/idle/idle_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/idle/idle_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/power/power_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/power/power_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/socket/udp_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_icon_image.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/state_store.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/updater/update_service.h View 1 chunk +1 line, -1 line 1 comment Download
M extensions/browser/updater/update_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/verified_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/simple_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/webview_info.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_test.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/permissions/api_permission_set.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/base_set_operators.h View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Devlin
Random cleanup time!
4 years, 5 months ago (2016-07-08 20:32:20 UTC) #5
lazyboy
Love this one, thanks! LGTM. https://codereview.chromium.org/2133203002/diff/40001/extensions/browser/updater/update_service.h File extensions/browser/updater/update_service.h (right): https://codereview.chromium.org/2133203002/diff/40001/extensions/browser/updater/update_service.h#newcode51 extensions/browser/updater/update_service.h:51: void StartUpdateCheck(const std::vector<std::string>& extension_ids); ...
4 years, 5 months ago (2016-07-08 20:56:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133203002/40001
4 years, 5 months ago (2016-07-08 22:17:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-08 22:22:56 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 22:23:08 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 22:24:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a0942f1975a6c8dc8f345fa336f1facbc9d571e
Cr-Commit-Position: refs/heads/master@{#404509}

Powered by Google App Engine
This is Rietveld 408576698