extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc - Issue 2133203002: [Extensions] Code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

Issue 2133203002: [Extensions] Code cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/execute_code_function.h ('k') | extensions/browser/api/idle/idle_manager.h » ('j') | extensions/browser/updater/update_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

diff --git a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc b/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

index 727824f10c047bf839721324c61fd7269a01b3ad..5e15ed66caeaf03115c20c9df81b6cb6a41b5bd0 100644

--- a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

+++ b/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

@@ -36,7 +36,7 @@ bool ExtensionViewInternalExtensionFunction::RunAsync() {

// Checks the validity of |src|, including that it follows the chrome extension

// scheme and that its extension ID is valid.

// Returns true if |src| is valid.

-bool IsSrcValid(GURL src) {

+bool IsSrcValid(const GURL& src) {

// Check if src is valid and matches the extension scheme.

if (!src.is_valid() || !src.SchemeIs(kExtensionScheme))

return false;