extensions/common/manifest_test.cc - Issue 2133203002: [Extensions] Code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_test.cc

Issue 2133203002: [Extensions] Code cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_test.cc

diff --git a/extensions/common/manifest_test.cc b/extensions/common/manifest_test.cc

index 2a43ed8ef25178ef8db882c3c771c82a910964e7..6a966e60f0170353921aa8c48c7a68b0762a17fd 100644

--- a/extensions/common/manifest_test.cc

+++ b/extensions/common/manifest_test.cc

@@ -91,7 +91,8 @@ ManifestTest::ManifestData::~ManifestData() {

}

base::DictionaryValue* ManifestTest::ManifestData::GetManifest(

- base::FilePath test_data_dir, std::string* error) const {

+ const base::FilePath& test_data_dir,

+ std::string* error) const {

if (manifest_)

return manifest_;