Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/verified_contents.cc

Issue 2133203002: [Extensions] Code cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/browser/updater/update_service.h ('K') | « extensions/browser/updater/update_service.cc ('k') | extensions/common/api/sockets/sockets_manifest_permission_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/verified_contents.cc
diff --git a/extensions/browser/verified_contents.cc b/extensions/browser/verified_contents.cc
index 9fdae10b9e59587d5f28cb70b3453f965c3444fa..b8acb9cba8c6db68c17fe1afab7068a965d7b32f 100644
--- a/extensions/browser/verified_contents.cc
+++ b/extensions/browser/verified_contents.cc
@@ -44,8 +44,8 @@ const char kWebstoreKId[] = "webstore";
// Helper function to iterate over a list of dictionaries, returning the
// dictionary that has |key| -> |value| in it, if any, or NULL.
DictionaryValue* FindDictionaryWithValue(const ListValue* list,
- std::string key,
- std::string value) {
+ const std::string& key,
+ const std::string& value) {
for (const auto& i : *list) {
DictionaryValue* dictionary;
if (!i->GetAsDictionary(&dictionary))
« extensions/browser/updater/update_service.h ('K') | « extensions/browser/updater/update_service.cc ('k') | extensions/common/api/sockets/sockets_manifest_permission_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698