extensions/common/extension_resource_unittest.cc - Issue 2133203002: [Extensions] Code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_resource_unittest.cc

Issue 2133203002: [Extensions] Code cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/extension_resource_unittest.cc

diff --git a/extensions/common/extension_resource_unittest.cc b/extensions/common/extension_resource_unittest.cc

index fb974d9f627e8d1d8f7f66444a5f4f9ae2f45034..097793f8052d2e6a85aa317ae65524db0f5574b7 100644

--- a/extensions/common/extension_resource_unittest.cc

+++ b/extensions/common/extension_resource_unittest.cc

@@ -149,7 +149,7 @@ TEST(ExtensionResourceTest, CreateWithAllResourcesOnDisk) {

std::string extension_id = crx_file::id_util::GenerateId("test");

ExtensionResource resource(extension_id, temp.path(),

base::FilePath().AppendASCII(filename));

- base::FilePath resolved_path = resource.GetFilePath();

+ const base::FilePath& resolved_path = resource.GetFilePath();

base::FilePath expected_path;

// Expect default path only, since fallback logic is disabled.