extensions/common/features/simple_feature.cc - Issue 2133203002: [Extensions] Code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/simple_feature.cc

Issue 2133203002: [Extensions] Code cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/simple_feature.cc

diff --git a/extensions/common/features/simple_feature.cc b/extensions/common/features/simple_feature.cc

index 9abc1b4f39224eed5f27a682b50d65fa06c18f43..8833fb2332821b3363f3e0491c6ca30f87b95780 100644

--- a/extensions/common/features/simple_feature.cc

+++ b/extensions/common/features/simple_feature.cc

@@ -306,7 +306,7 @@ std::string SimpleFeature::Parse(const base::DictionaryValue* dictionary) {

for (base::DictionaryValue::Iterator it(*dictionary);

!it.IsAtEnd();

it.Advance()) {

- std::string key = it.key();

+ const std::string& key = it.key();

const base::Value* value = &it.value();

if (key == "matches") {

ParseURLPatterns(dictionary, "matches", &matches_);