extensions/common/api/sockets/sockets_manifest_permission_unittest.cc - Issue 2133203002: [Extensions] Code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/sockets/sockets_manifest_permission_unittest.cc

Issue 2133203002: [Extensions] Code cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/updater/update_service.h ('K') | « extensions/browser/verified_contents.cc ('k') | extensions/common/extension_resource_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/sockets/sockets_manifest_permission_unittest.cc

diff --git a/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc b/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc

index fa970cecafc5401305c35ff627931b2b7838502a..c7b1774b0e26655d331abdf1862c0e8b19c814f6 100644

--- a/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc

+++ b/extensions/common/api/sockets/sockets_manifest_permission_unittest.cc

@@ -84,7 +84,7 @@ struct CheckFormatEntry {

};

static testing::AssertionResult CheckFormat(

- std::multiset<CheckFormatEntry> permissions,

+ const std::multiset<CheckFormatEntry>& permissions,

const std::string& json) {

std::unique_ptr<SocketsManifestPermission> permission(

PermissionFromJSON(json));

« extensions/browser/updater/update_service.h ('K') | « extensions/browser/verified_contents.cc ('k') | extensions/common/extension_resource_unittest.cc » ('j') | no next file with comments »