Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2131993002: Delete the audio modem and copresence private APIs. (Closed)

Created:
4 years, 5 months ago by Charlie
Modified:
4 years, 5 months ago
CC:
arv+watch_chromium.org, blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, droger+watchlist_chromium.org, extensions-reviews_chromium.org, rkc, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@eol
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the audio modem and copresence private APIs. BUG=496900 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation R=brettw@chromium.org, isherman@chromium.org, jochen@chromium.org, rockot@chromium.org, xiyuan@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6f7eddb619672d522bbbedf8db3d7136d363117e

Patch Set 1 #

Patch Set 2 : Updating histograms #

Patch Set 3 : Reverting ppapi tests file #

Patch Set 4 : Syncing to head #

Patch Set 5 : Syncing, fixing gyp build #

Patch Set 6 : Sync again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4988 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/copresence/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/copresence/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/copresence/chrome_whispernet_client.h View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/copresence/chrome_whispernet_client.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 1 chunk +0 lines, -375 lines 0 comments Download
D chrome/browser/copresence/chrome_whispernet_config.h View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/audio_modem/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/audio_modem/audio_modem_api.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/extensions/api/audio_modem/audio_modem_api.cc View 1 chunk +0 lines, -366 lines 0 comments Download
D chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc View 1 chunk +0 lines, -395 lines 0 comments Download
D chrome/browser/extensions/api/copresence_private/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/copresence_private/copresence_private_api.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/extensions/api/copresence_private/copresence_private_api.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M chrome/browser/extensions/component_extensions_whitelist/whitelist.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/background.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/js/init.js View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/js/nacl.js View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/js/wrapper.js View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/whispernet_proxy/whispernet_proxy.nmf.png View Binary file 0 comments Download
D chrome/browser/resources/whispernet_proxy/whispernet_proxy_pnacl.pexe.png View Binary file 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 4 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/audio_modem.idl View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/common/extensions/api/copresence_private.idl View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 2 chunks +0 lines, -9 lines 0 comments Download
M components/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/OWNERS View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D components/audio_modem.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
D components/audio_modem/BUILD.gn View 1 chunk +0 lines, -72 lines 0 comments Download
D components/audio_modem/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/audio_modem/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/audio_modem/audio_modem_switches.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/audio_modem/audio_modem_switches.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D components/audio_modem/audio_player.h View 1 chunk +0 lines, -43 lines 0 comments Download
D components/audio_modem/audio_player_impl.h View 1 chunk +0 lines, -89 lines 0 comments Download
D components/audio_modem/audio_player_impl.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D components/audio_modem/audio_player_unittest.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D components/audio_modem/audio_recorder.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/audio_modem/audio_recorder_impl.h View 1 chunk +0 lines, -102 lines 0 comments Download
D components/audio_modem/audio_recorder_impl.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D components/audio_modem/audio_recorder_unittest.cc View 1 chunk +0 lines, -282 lines 0 comments Download
D components/audio_modem/constants.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/audio_modem/modem_impl.h View 1 chunk +0 lines, -127 lines 0 comments Download
D components/audio_modem/modem_impl.cc View 1 chunk +0 lines, -344 lines 0 comments Download
D components/audio_modem/modem_unittest.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D components/audio_modem/public/audio_modem_types.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/audio_modem/public/modem.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/audio_modem/public/whispernet_client.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/audio_modem/test/random_samples.h View 1 chunk +0 lines, -28 lines 0 comments Download
D components/audio_modem/test/random_samples.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D components/audio_modem/test/stub_modem.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/audio_modem/test/stub_modem.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D components/audio_modem/test/stub_whispernet_client.h View 1 chunk +0 lines, -58 lines 0 comments Download
D components/audio_modem/test/stub_whispernet_client.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M components/components.gyp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 4 3 chunks +0 lines, -9 lines 0 comments Download
M extensions/browser/extension_event_histogram_value.h View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 49 (23 generated)
Charlie
4 years, 5 months ago (2016-07-08 14:39:02 UTC) #3
Charlie
4 years, 5 months ago (2016-07-08 14:42:37 UTC) #5
Ken Rockot(use gerrit already)
rs lgtm
4 years, 5 months ago (2016-07-08 15:50:09 UTC) #6
xiyuan
lgtm +rkc fyi
4 years, 5 months ago (2016-07-08 16:07:30 UTC) #7
Charlie
4 years, 5 months ago (2016-07-10 23:22:41 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-11 14:34:33 UTC) #10
Charlie
4 years, 5 months ago (2016-07-11 15:12:35 UTC) #12
Ilya Sherman
histograms.xml and enum changes lgtm
4 years, 5 months ago (2016-07-11 19:19:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131993002/60001
4 years, 5 months ago (2016-07-11 19:27:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/932)
4 years, 5 months ago (2016-07-11 19:37:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131993002/80001
4 years, 5 months ago (2016-07-11 19:46:33 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/935)
4 years, 5 months ago (2016-07-11 19:57:25 UTC) #23
brettw
LGTM, thanks!
4 years, 5 months ago (2016-07-11 20:51:29 UTC) #24
jam
what about components/copresence, will that be deleted next?
4 years, 5 months ago (2016-07-11 20:52:40 UTC) #26
Charlie
On 2016/07/11 20:52:40, jam wrote: > what about components/copresence, will that be deleted next? It's ...
4 years, 5 months ago (2016-07-11 20:56:33 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131993002/100001
4 years, 5 months ago (2016-07-11 21:10:47 UTC) #30
jam
On 2016/07/11 20:56:33, Charlie wrote: > On 2016/07/11 20:52:40, jam wrote: > > what about ...
4 years, 5 months ago (2016-07-11 23:10:43 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190483) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-11 23:12:49 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131993002/100001
4 years, 5 months ago (2016-07-12 01:00:07 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190734)
4 years, 5 months ago (2016-07-12 03:08:58 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131993002/100001
4 years, 5 months ago (2016-07-12 03:27:09 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190981)
4 years, 5 months ago (2016-07-12 06:55:04 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131993002/100001
4 years, 5 months ago (2016-07-12 07:15:44 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191124)
4 years, 5 months ago (2016-07-12 11:21:26 UTC) #45
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/6f7eddb619672d522bbbedf8db3d7136d363117e Cr-Commit-Position: refs/heads/master@{#404803}
4 years, 5 months ago (2016-07-12 11:35:19 UTC) #47
Charlie
4 years, 5 months ago (2016-07-12 11:36:26 UTC) #49
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
6f7eddb619672d522bbbedf8db3d7136d363117e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698