Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2130803002: Deleting the copresence API. (Closed)

Created:
4 years, 5 months ago by Charlie
Modified:
4 years, 5 months ago
CC:
arv+watch_chromium.org, blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, droger+watchlist_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, rkc, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deleting the copresence API. BUG=496899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cc16886e9facbcb54fa86bbef0dc0e893e36a4fc Cr-Commit-Position: refs/heads/master@{#404407}

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7340 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -49 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/api_registration.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/copresence/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/copresence/copresence_api.h View 1 chunk +0 lines, -153 lines 0 comments Download
D chrome/browser/extensions/api/copresence/copresence_api.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D chrome/browser/extensions/api/copresence/copresence_api_unittest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
D chrome/browser/extensions/api/copresence/copresence_translations.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/extensions/api/copresence/copresence_translations.cc View 1 chunk +0 lines, -234 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/copresence.css View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/resources/copresence.html View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/resources/copresence.js View 1 chunk +0 lines, -130 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/copresence_ui.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/webui/copresence_ui.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/webui/copresence_ui_handler.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/webui/copresence_ui_handler.cc View 1 chunk +0 lines, -214 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/common/extensions/api/copresence.idl View 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/copresence.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/manifest_handlers/copresence_manifest.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/copresence_manifest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/url_constants.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 3 chunks +0 lines, -13 lines 0 comments Download
D components/copresence.gypi View 1 chunk +0 lines, -98 lines 0 comments Download
D components/copresence/BUILD.gn View 1 chunk +0 lines, -87 lines 0 comments Download
D components/copresence/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/copresence/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/copresence/copresence_manager_impl.h View 1 chunk +0 lines, -105 lines 0 comments Download
D components/copresence/copresence_manager_impl.cc View 1 chunk +0 lines, -270 lines 0 comments Download
D components/copresence/copresence_state_impl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D components/copresence/copresence_state_impl.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D components/copresence/copresence_state_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D components/copresence/copresence_switches.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/copresence/copresence_switches.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_handler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_handler_impl.h View 1 chunk +0 lines, -86 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_handler_impl.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_handler_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_list.h View 1 chunk +0 lines, -88 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_list.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D components/copresence/handlers/audio/audio_directive_list_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D components/copresence/handlers/audio/tick_clock_ref_counted.h View 1 chunk +0 lines, -41 lines 0 comments Download
D components/copresence/handlers/audio/tick_clock_ref_counted.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D components/copresence/handlers/directive_handler.h View 1 chunk +0 lines, -50 lines 0 comments Download
D components/copresence/handlers/directive_handler_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/copresence/handlers/directive_handler_impl.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D components/copresence/handlers/directive_handler_unittest.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D components/copresence/handlers/gcm_handler.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/copresence/handlers/gcm_handler_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D components/copresence/handlers/gcm_handler_impl.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D components/copresence/handlers/gcm_handler_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D components/copresence/proto/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D components/copresence/proto/codes.proto View 1 chunk +0 lines, -23 lines 0 comments Download
D components/copresence/proto/config_data.proto View 1 chunk +0 lines, -91 lines 0 comments Download
D components/copresence/proto/data.proto View 1 chunk +0 lines, -138 lines 0 comments Download
D components/copresence/proto/enums.proto View 1 chunk +0 lines, -91 lines 0 comments Download
D components/copresence/proto/identity.proto View 1 chunk +0 lines, -20 lines 0 comments Download
D components/copresence/proto/push_message.proto View 1 chunk +0 lines, -20 lines 0 comments Download
D components/copresence/proto/rpcs.proto View 1 chunk +0 lines, -67 lines 0 comments Download
D components/copresence/public/copresence_constants.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/copresence/public/copresence_delegate.h View 1 chunk +0 lines, -77 lines 0 comments Download
D components/copresence/public/copresence_manager.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/copresence/public/copresence_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/copresence/public/copresence_state.h View 1 chunk +0 lines, -47 lines 0 comments Download
D components/copresence/rpc/http_post.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/copresence/rpc/http_post.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D components/copresence/rpc/http_post_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D components/copresence/rpc/rpc_handler.h View 1 chunk +0 lines, -213 lines 0 comments Download
D components/copresence/rpc/rpc_handler.cc View 1 chunk +0 lines, -620 lines 0 comments Download
D components/copresence/rpc/rpc_handler_unittest.cc View 1 chunk +0 lines, -348 lines 0 comments Download
D components/copresence/test/fake_directive_handler.h View 1 chunk +0 lines, -47 lines 0 comments Download
D components/copresence/test/fake_directive_handler.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D components/copresence/timed_map.h View 1 chunk +0 lines, -114 lines 0 comments Download
D components/copresence/timed_map_unittest.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D components/copresence/tokens.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/copresence/tokens.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M extensions/browser/extension_event_histogram_value.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_constants.h View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/common/manifest_constants.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 4 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (7 generated)
Charlie
We are finally removing the copresence API from Chrome. It has been replaced by an ...
4 years, 5 months ago (2016-07-07 15:53:00 UTC) #3
Ken Rockot(use gerrit already)
rs lgtm
4 years, 5 months ago (2016-07-07 16:09:32 UTC) #4
xiyuan
lgtm https://codereview.chromium.org/2130803002/diff/1/extensions/common/permissions/api_permission.h File extensions/common/permissions/api_permission.h (right): https://codereview.chromium.org/2130803002/diff/1/extensions/common/permissions/api_permission.h#newcode82 extensions/common/permissions/api_permission.h:82: kCopresence, // Deleted nit: kCopresence -> kDeletedCopresence so ...
4 years, 5 months ago (2016-07-07 16:16:13 UTC) #5
Charlie
https://codereview.chromium.org/2130803002/diff/1/extensions/common/permissions/api_permission.h File extensions/common/permissions/api_permission.h (right): https://codereview.chromium.org/2130803002/diff/1/extensions/common/permissions/api_permission.h#newcode82 extensions/common/permissions/api_permission.h:82: kCopresence, // Deleted On 2016/07/07 16:16:13, xiyuan wrote: > ...
4 years, 5 months ago (2016-07-07 20:06:18 UTC) #7
Ilya Sherman
Please also run the scripts to update histograms.xml
4 years, 5 months ago (2016-07-07 20:15:11 UTC) #8
Charlie
On 2016/07/07 20:15:11, Ilya Sherman wrote: > Please also run the scripts to update histograms.xml ...
4 years, 5 months ago (2016-07-07 20:21:10 UTC) #9
Ilya Sherman
histograms.xml and enum changes lgtm
4 years, 5 months ago (2016-07-07 22:57:30 UTC) #10
Charlie
4 years, 5 months ago (2016-07-08 03:07:03 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-08 12:54:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130803002/40001
4 years, 5 months ago (2016-07-08 14:17:57 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 16:42:45 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 16:45:02 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc16886e9facbcb54fa86bbef0dc0e893e36a4fc
Cr-Commit-Position: refs/heads/master@{#404407}

Powered by Google App Engine
This is Rietveld 408576698