Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 212753002: Use fixed function pipeline only when drawing paths (Closed)

Created:
6 years, 9 months ago by Kimmo Kinnunen
Modified:
6 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Use fixed function pipeline only when drawing paths Use fixed function pipeline only when drawing paths. Previously FF vertex shader was used when drawing normal geometry if path rendering was enabled. This is required to make Chromium integration easier. This way fixed function vertex shading, including vertexshader-less programs, need not be implemented in the Chromium command buffer. Removes FF TexGen functionality, as it is not used anymore. Likewise removes the fixedFunctionSupport GL capability flag. BUG=chromium:344330 Committed: http://code.google.com/p/skia/source/detail?r=14334

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -204 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 5 chunks +1 line, -6 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 4 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 8 chunks +25 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 4 chunks +42 lines, -79 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 2 chunks +2 lines, -22 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kimmo Kinnunen
As per the Chromium cmd buffer design doc If this is ok, or even if ...
6 years, 9 months ago (2014-03-26 12:05:02 UTC) #1
bsalomon
It lgtm. I submitted a bunch of try bots.
6 years, 9 months ago (2014-03-26 13:52:54 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-23 15:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/212753002/210001
6 years, 8 months ago (2014-04-23 15:09:12 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 19:26:35 UTC) #5
Message was sent while issue was closed.
Change committed as 14334

Powered by Google App Engine
This is Rietveld 408576698