Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2121133002: Remove provider index from Android NewTabPage histograms (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dewittj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove provider index from Android NewTabPage histograms BUG=625161 Committed: https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13 Cr-Commit-Position: refs/heads/master@{#405129}

Patch Set 1 #

Patch Set 2 : fix tests build #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -89 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java View 4 chunks +1 line, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java View 1 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.h View 2 chunks +1 line, -5 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 9 chunks +8 lines, -22 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +31 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
Marc Treib
PTAL! (Based on dewittj's https://codereview.chromium.org/2105933002 which should hopefully land soon)
4 years, 5 months ago (2016-07-05 10:26:29 UTC) #2
Bernhard Bauer
LGTM!
4 years, 5 months ago (2016-07-05 10:56:57 UTC) #3
Marc Treib
+holte for histograms.xml. PTAL!
4 years, 5 months ago (2016-07-05 11:31:26 UTC) #5
Steven Holte
lgtm
4 years, 5 months ago (2016-07-06 18:38:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121133002/40001
4 years, 5 months ago (2016-07-13 08:57:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/103028)
4 years, 5 months ago (2016-07-13 09:58:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121133002/40001
4 years, 5 months ago (2016-07-13 09:59:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/103056)
4 years, 5 months ago (2016-07-13 10:56:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121133002/40001
4 years, 5 months ago (2016-07-13 11:39:29 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 12:41:40 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 12:42:56 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13
Cr-Commit-Position: refs/heads/master@{#405129}

Powered by Google App Engine
This is Rietveld 408576698