Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java

Issue 2121133002: Remove provider index from Android NewTabPage histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dewittj
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
index 1eaecdbd1d95fa949803987388d8fd82a0919e3b..0207bc294cbd2ccbaa6efc51404526f31fb18a27 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
@@ -54,7 +54,6 @@ public class MostVisitedItem implements OnCreateContextMenuListener,
private int mIndex;
private int mTileType;
private int mSource;
- private int mProviderIndex;
private View mView;
/**
@@ -69,12 +68,9 @@ public class MostVisitedItem implements OnCreateContextMenuListener,
* @param offlineAvailable Whether there is an offline copy of the URL available.
* @param index The index of this item in the list of most visited items.
* @param source The {@link MostVisitedSource} that generated this item.
- * @param providerIndex If this item comes from {@code MostVisitedSource.SUGGESTIONS_SERVICE},
- * this is the index of the source of the suggestion.
*/
public MostVisitedItem(MostVisitedItemManager manager, String title, String url,
- String whitelistIconPath, boolean offlineAvailable, int index, int source,
- int providerIndex) {
+ String whitelistIconPath, boolean offlineAvailable, int index, int source) {
mManager = manager;
mTitle = title;
mUrl = url;
@@ -83,7 +79,6 @@ public class MostVisitedItem implements OnCreateContextMenuListener,
mIndex = index;
mTileType = MostVisitedTileType.NONE;
mSource = source;
- mProviderIndex = index;
}
/**
@@ -170,13 +165,6 @@ public class MostVisitedItem implements OnCreateContextMenuListener,
return mSource;
}
- /**
- * @return The provider index of this item. Used for metrics tracking.
- */
- public int getProviderIndex() {
- return mProviderIndex;
- }
-
@Override
public void onCreateContextMenu(ContextMenu menu, View v, ContextMenuInfo menuInfo) {
mManager.onCreateContextMenu(menu, this);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698