Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3930)

Unified Diff: chrome/browser/android/ntp/most_visited_sites_bridge.cc

Issue 2121133002: Remove provider index from Android NewTabPage histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dewittj
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp/most_visited_sites_bridge.h ('k') | components/ntp_tiles/most_visited_sites.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/ntp/most_visited_sites_bridge.cc
diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.cc b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
index 92e83a83873f98177170e27389b10b137b879255..6272acfe2502daf26c0ad416156cd210a94216bc 100644
--- a/chrome/browser/android/ntp/most_visited_sites_bridge.cc
+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
@@ -120,26 +120,22 @@ void MostVisitedSitesBridge::JavaObserver::OnMostVisitedURLsAvailable(
std::vector<std::string> urls;
std::vector<std::string> whitelist_icon_paths;
std::vector<int> sources;
- std::vector<int> provider_indexes;
titles.reserve(suggestions.size());
urls.reserve(suggestions.size());
whitelist_icon_paths.reserve(suggestions.size());
sources.reserve(suggestions.size());
- provider_indexes.reserve(suggestions.size());
for (const auto& suggestion : suggestions) {
titles.emplace_back(suggestion.title);
urls.emplace_back(suggestion.url.spec());
whitelist_icon_paths.emplace_back(suggestion.whitelist_icon_path.value());
sources.emplace_back(suggestion.source);
- provider_indexes.emplace_back(suggestion.provider_index);
}
Java_MostVisitedURLsObserver_onMostVisitedURLsAvailable(
env, observer_.obj(), ToJavaArrayOfStrings(env, titles).obj(),
ToJavaArrayOfStrings(env, urls).obj(),
ToJavaArrayOfStrings(env, whitelist_icon_paths).obj(),
- ToJavaIntArray(env, sources).obj(),
- ToJavaIntArray(env, provider_indexes).obj());
+ ToJavaIntArray(env, sources).obj());
}
void MostVisitedSitesBridge::JavaObserver::OnPopularURLsAvailable(
@@ -204,18 +200,14 @@ void MostVisitedSitesBridge::RecordTileTypeMetrics(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
const JavaParamRef<jintArray>& jtile_types,
- const JavaParamRef<jintArray>& jsources,
- const JavaParamRef<jintArray>& jprovider_indices) {
+ const JavaParamRef<jintArray>& jsources) {
std::vector<int> tile_types;
std::vector<int> sources;
- std::vector<int> provider_indices;
base::android::JavaIntArrayToIntVector(env, jtile_types, &tile_types);
base::android::JavaIntArrayToIntVector(env, jsources, &sources);
- base::android::JavaIntArrayToIntVector(env, jprovider_indices,
- &provider_indices);
- most_visited_.RecordTileTypeMetrics(tile_types, sources, provider_indices);
+ most_visited_.RecordTileTypeMetrics(tile_types, sources);
}
void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(
« no previous file with comments | « chrome/browser/android/ntp/most_visited_sites_bridge.h ('k') | components/ntp_tiles/most_visited_sites.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698