MostVisitedSites: simplify prefs

MostVisitedSites: simplify prefs

BUG=none

Committed: https://crrev.com/cd3d2ef0eaa8c1f969a9f365fa8f8d41dd47d3e4
Cr-Commit-Position: refs/heads/master@{#405193}

[Marc Treib, 2016-07-08 09:15:25]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[sfiera, 2016-07-08 09:27:04]

There's an actual change in the handling of preferences here, with way too much
"random cleanup" mixed in for my tastes... of course, I can't approve anyway, so
you can see what bauerb thinks :)

[Marc Treib, 2016-07-08 09:50:03]

Description was changed from

==========
MostVisitedSites: deprecate unnecessary prefs
plus some other random cleanup

BUG=none
==========

to

==========
MostVisitedSites: simplify prefs

BUG=none
==========

[Marc Treib, 2016-07-08 09:50:32]

On 2016/07/08 09:27:04, sfiera wrote:
> There's an actual change in the handling of preferences here, with way too
much
> "random cleanup" mixed in for my tastes... of course, I can't approve anyway,
so
> you can see what bauerb thinks :)

Fair enough. I've reverted all the random cleanup (will upload as a separate
CL). PTAL again :)

[sfiera, 2016-07-08 09:59:15]

LGTM

https://codereview.chromium.org/2131863002/diff/40001/components/ntp_tiles/mo...
File components/ntp_tiles/most_visited_sites.cc (right):

https://codereview.chromium.org/2131863002/diff/40001/components/ntp_tiles/mo...
components/ntp_tiles/most_visited_sites.cc:86:
prefs->GetList(ntp_tiles::prefs::kDeprecatedNTPSuggestionsIsPersonal);
How important is this to preserve? Seems like a user would hit popular sites
once after upgrading, then never again, using maybe 1kB of unnecessary data and
delaying startup after first launch by a few ms.

There's nothing wrong with keeping it, though.

[Marc Treib, 2016-07-08 10:02:17]

https://codereview.chromium.org/2131863002/diff/40001/components/ntp_tiles/mo...
File components/ntp_tiles/most_visited_sites.cc (right):

https://codereview.chromium.org/2131863002/diff/40001/components/ntp_tiles/mo...
components/ntp_tiles/most_visited_sites.cc:86:
prefs->GetList(ntp_tiles::prefs::kDeprecatedNTPSuggestionsIsPersonal);
On 2016/07/08 09:59:15, sfiera wrote:
> How important is this to preserve? Seems like a user would hit popular sites
> once after upgrading, then never again, using maybe 1kB of unnecessary data
and
> delaying startup after first launch by a few ms.
> 
> There's nothing wrong with keeping it, though.

Well, accumulated, it'd still be a few hundred million unnecessary requests.
Since we have some other "remove after M55" code around, I see no reason not to
keep this as well.

[Marc Treib, 2016-07-08 10:02:48]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-07-08 10:02:48]

As always, +bauerb for approval

[Bernhard Bauer, 2016-07-08 10:08:02]

lgtm

[Marc Treib, 2016-07-13 16:11:53]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-07-13 16:11:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sfiera@chromium.org
Link to the patchset: https://codereview.chromium.org/2131863002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-13 16:12:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:53:44]

Description was changed from

==========
MostVisitedSites: simplify prefs

BUG=none
==========

to

==========
MostVisitedSites: simplify prefs

BUG=none
==========

[commit-bot: I haz the power, 2016-07-13 16:53:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-13 16:53:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 16:55:20]

Description was changed from

==========
MostVisitedSites: simplify prefs

BUG=none
==========

to

==========
MostVisitedSites: simplify prefs

BUG=none

Committed: https://crrev.com/cd3d2ef0eaa8c1f969a9f365fa8f8d41dd47d3e4
Cr-Commit-Position: refs/heads/master@{#405193}
==========

[commit-bot: I haz the power, 2016-07-13 16:55:20]

Patchset 4 (id:??) landed as
https://crrev.com/cd3d2ef0eaa8c1f969a9f365fa8f8d41dd47d3e4
Cr-Commit-Position: refs/heads/master@{#405193}