Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

Issue 2121133002: Remove provider index from Android NewTabPage histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dewittj
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
index e9e02d512fdb45c22c4e27970eb68d01b1ca4ef0..08d747b4eb4fdad553bd89085d85ecbf3d3c6bf3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
@@ -28,7 +28,7 @@ public class MostVisitedSites {
*/
@CalledByNative("MostVisitedURLsObserver")
public void onMostVisitedURLsAvailable(String[] titles, String[] urls,
- String[] whitelistIconPaths, int[] sources, int[] providerIndexes);
+ String[] whitelistIconPaths, int[] sources);
/**
* This is called when the list of popular URLs is initially available or updated.
@@ -73,11 +73,10 @@ public class MostVisitedSites {
MostVisitedURLsObserver wrappedObserver = new MostVisitedURLsObserver() {
@Override
public void onMostVisitedURLsAvailable(String[] titles, String[] urls,
- String[] whitelistIconPaths, int[] sources, int[] providerIndexes) {
+ String[] whitelistIconPaths, int[] sources) {
// Don't notify observer if we've already been destroyed.
if (mNativeMostVisitedSitesBridge != 0) {
- observer.onMostVisitedURLsAvailable(
- titles, urls, whitelistIconPaths, sources, providerIndexes);
+ observer.onMostVisitedURLsAvailable(titles, urls, whitelistIconPaths, sources);
}
}
@Override
@@ -112,9 +111,8 @@ public class MostVisitedSites {
* @param tileTypes An array of values from MostVisitedTileType indicating the type of each
* tile that's currently showing.
*/
- public void recordTileTypeMetrics(int[] tileTypes, int[] sources, int[] providerIndices) {
- nativeRecordTileTypeMetrics(
- mNativeMostVisitedSitesBridge, tileTypes, sources, providerIndices);
+ public void recordTileTypeMetrics(int[] tileTypes, int[] sources) {
+ nativeRecordTileTypeMetrics(mNativeMostVisitedSitesBridge, tileTypes, sources);
}
/**
@@ -134,7 +132,7 @@ public class MostVisitedSites {
long nativeMostVisitedSitesBridge, String url,
boolean addUrl);
private native void nativeRecordTileTypeMetrics(long nativeMostVisitedSitesBridge,
- int[] tileTypes, int[] sources, int[] providerIndices);
+ int[] tileTypes, int[] sources);
private native void nativeRecordOpenedMostVisitedItem(
long nativeMostVisitedSitesBridge, int index, int tileType);

Powered by Google App Engine
This is Rietveld 408576698