Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2121133002: Remove provider index from Android NewTabPage histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dewittj
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 66e0e37e1748f2d1029ae1d7aa4c350550757b50..f4c7b76b2f2610a96828040c672629336b83fb00 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -816,7 +816,7 @@ public class NewTabPageView extends FrameLayout
@Override
public void onMostVisitedURLsAvailable(final String[] titles, final String[] urls,
- final String[] whitelistIconPaths, final int[] sources, final int[] providerIndexes) {
+ final String[] whitelistIconPaths, final int[] sources) {
Set<String> urlSet = new HashSet<>(Arrays.asList(urls));
// TODO(https://crbug.com/607573): We should show offline-available content in a nonblocking
@@ -825,15 +825,13 @@ public class NewTabPageView extends FrameLayout
mManager.getUrlsAvailableOffline(urlSet, new Callback<Set<String>>() {
@Override
public void onResult(Set<String> offlineUrls) {
- onOfflineUrlsAvailable(
- titles, urls, whitelistIconPaths, offlineUrls, sources, providerIndexes);
+ onOfflineUrlsAvailable(titles, urls, whitelistIconPaths, offlineUrls, sources);
}
});
}
private void onOfflineUrlsAvailable(final String[] titles, final String[] urls,
- final String[] whitelistIconPaths, final Set<String> offlineUrls, final int[] sources,
- final int[] providerIndexes) {
+ final String[] whitelistIconPaths, final Set<String> offlineUrls, final int[] sources) {
mMostVisitedLayout.removeAllViews();
MostVisitedItem[] oldItems = mMostVisitedItems;
@@ -849,7 +847,6 @@ public class NewTabPageView extends FrameLayout
final String title = titles[i];
final String whitelistIconPath = whitelistIconPaths[i];
final int source = sources[i];
- final int providerIndex = providerIndexes[i];
boolean offlineAvailable = offlineUrls.contains(url);
@@ -871,7 +868,7 @@ public class NewTabPageView extends FrameLayout
// If nothing can be reused, create a new item.
if (item == null) {
item = new MostVisitedItem(mManager, title, url, whitelistIconPath,
- offlineAvailable, i, source, providerIndex);
+ offlineAvailable, i, source);
View view =
mMostVisitedDesign.createMostVisitedItemView(inflater, item, isInitialLoad);
item.initView(view);

Powered by Google App Engine
This is Rietveld 408576698