Replace ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace deprecated ASSERT-family macros.

- ASSERT* -> DCHECK*
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

This CL has no behavior changes.

BUG=596760
Committed: https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209
Cr-Commit-Position: refs/heads/master@{#402132}

[tkent, 2016-06-27 05:52:15]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-06-27 05:52:16]

yosin@, would you review this please?

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
(right):

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp:146:
ASSERT(it != m_members.end());
I'd like to replace this later because DCHECK_NE for this requires operator<<
for WTF::HashTableIteratorAdaptor.

[yosin_UTC9, 2016-06-27 06:28:39]

lgtm

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/FormController.cpp (right):

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/FormController.cpp:265:
DCHECK_GT(it->value.size(), 0u);
Q: Is DCHECK_NE(it->value.size(), 0u) better?

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
(right):

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp:146:
ASSERT(it != m_members.end());
On 2016/06/27 at 05:52:15, tkent wrote:
> I'd like to replace this later because DCHECK_NE for this requires operator<<
for WTF::HashTableIteratorAdaptor.

FYI: I've never define operator<<() for iterator so far.

[tkent, 2016-06-27 06:38:10]

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/FormController.cpp (right):

https://codereview.chromium.org/2097313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/FormController.cpp:265:
DCHECK_GT(it->value.size(), 0u);
On 2016/06/27 at 06:28:38, Yosi_UTC9 wrote:
> Q: Is DCHECK_NE(it->value.size(), 0u) better?

I think either is ok because it->values.size() is a unsigned value.

[tkent, 2016-06-27 06:38:16]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-06-27 06:38:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 07:50:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 07:51:17]

Description was changed from

==========
Replase ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace deprecated ASSERT-family macros.

- ASSERT* -> DCHECK*
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

This CL has no behavior changes.

BUG=596760
==========

to

==========
Replase ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace deprecated ASSERT-family macros.

- ASSERT* -> DCHECK*
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

This CL has no behavior changes.

BUG=596760

Committed: https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209
Cr-Commit-Position: refs/heads/master@{#402132}
==========

[commit-bot: I haz the power, 2016-06-27 07:51:18]

Patchset 1 (id:??) landed as
https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209
Cr-Commit-Position: refs/heads/master@{#402132}

[tkent, 2016-06-27 08:01:47]

Description was changed from

==========
Replase ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace deprecated ASSERT-family macros.

- ASSERT* -> DCHECK*
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

This CL has no behavior changes.

BUG=596760

Committed: https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209
Cr-Commit-Position: refs/heads/master@{#402132}
==========

to

==========
Replace ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace deprecated ASSERT-family macros.

- ASSERT* -> DCHECK*
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

This CL has no behavior changes.

BUG=596760

Committed: https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209
Cr-Commit-Position: refs/heads/master@{#402132}
==========