third_party/WebKit/Source/core/html/forms/SearchInputType.cpp - Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp ('K') | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/StepRange.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp b/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

index bb7db83a37d5f9220829d95b3466a04909c6e709..32d78bbf07f066cb550449c676dcd80e9846133f 100644

--- a/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

@@ -81,8 +81,8 @@ void SearchInputType::createShadowSubtree()

TextFieldInputType::createShadowSubtree();

Element* container = containerElement();

Element* viewPort = element().userAgentShadowRoot()->getElementById(ShadowElementNames::editingViewPort());

- ASSERT(container);

- ASSERT(viewPort);

+ DCHECK(container);

+ DCHECK(viewPort);

container->insertBefore(SearchFieldCancelButtonElement::create(element().document()), viewPort->nextSibling());

}

@@ -105,7 +105,7 @@ void SearchInputType::handleKeydownEvent(KeyboardEvent* event)

void SearchInputType::startSearchEventTimer()

{

- ASSERT(element().layoutObject());

+ DCHECK(element().layoutObject());

unsigned length = element().innerEditorValue().length();

if (!length) {