third_party/WebKit/Source/core/html/forms/TimeInputType.cpp - Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp ('K') | « third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/WeekInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp b/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

index 475d4e7cb509771f479621c2ebffc1102865f164..89f5705901b05ced46e0560218cdf14634ae7d16 100644

--- a/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

@@ -76,7 +76,7 @@ Decimal TimeInputType::defaultValueForStepUp() const

DateComponents date;

date.setMillisecondsSinceMidnight(convertToLocalTime(currentTimeMS()));

double milliseconds = date.millisecondsSinceEpoch();

- ASSERT(std::isfinite(milliseconds));

+ DCHECK(std::isfinite(milliseconds));

return Decimal::fromDouble(milliseconds);

}

@@ -89,14 +89,14 @@ StepRange TimeInputType::createStepRange(AnyStepHandling anyStepHandling) const

bool TimeInputType::parseToDateComponentsInternal(const String& string, DateComponents* out) const

{

- ASSERT(out);

+ DCHECK(out);

unsigned end;

return out->parseTime(string, 0, end) && end == string.length();

}

bool TimeInputType::setMillisecondToDateComponents(double value, DateComponents* date) const

{

- ASSERT(date);

+ DCHECK(date);

return date->setMillisecondsSinceMidnight(value);

}