Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp b/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
index 30e0bdf40bc25357290a2d69eebdfd86628860f1..117d4c0498558a3196d7ac5f9d1233b3b580f6dc 100644
--- a/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
+++ b/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
@@ -278,7 +278,7 @@ void MultipleFieldsTemporalInputTypeView::pickerIndicatorChooseValue(const Strin
void MultipleFieldsTemporalInputTypeView::pickerIndicatorChooseValue(double value)
{
- ASSERT(std::isfinite(value) || std::isnan(value));
+ DCHECK(std::isfinite(value) || std::isnan(value));
if (std::isnan(value))
element().setValue(emptyString(), DispatchInputAndChangeEvent);
else
@@ -346,13 +346,13 @@ PassRefPtr<ComputedStyle> MultipleFieldsTemporalInputTypeView::customStyleForLay
void MultipleFieldsTemporalInputTypeView::createShadowSubtree()
{
- ASSERT(element().shadow());
+ DCHECK(element().shadow());
// Element must not have a layoutObject here, because if it did
// DateTimeEditElement::customStyleForLayoutObject() is called in appendChild()
// before the field wrapper element is created.
// FIXME: This code should not depend on such craziness.
- ASSERT(!element().layoutObject());
+ DCHECK(!element().layoutObject());
Document& document = element().document();
ContainerNode* container = element().userAgentShadowRoot();
@@ -371,7 +371,7 @@ void MultipleFieldsTemporalInputTypeView::createShadowSubtree()
void MultipleFieldsTemporalInputTypeView::destroyShadowSubtree()
{
- ASSERT(!m_isDestroyingShadowSubtree);
+ DCHECK(!m_isDestroyingShadowSubtree);
m_isDestroyingShadowSubtree = true;
if (SpinButtonElement* element = spinButtonElement())
element->removeSpinButtonOwner();
@@ -575,7 +575,7 @@ void MultipleFieldsTemporalInputTypeView::hidePickerIndicator()
if (!m_pickerIndicatorIsVisible)
return;
m_pickerIndicatorIsVisible = false;
- ASSERT(pickerIndicatorElement());
+ DCHECK(pickerIndicatorElement());
pickerIndicatorElement()->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
}
@@ -584,7 +584,7 @@ void MultipleFieldsTemporalInputTypeView::showPickerIndicator()
if (m_pickerIndicatorIsVisible)
return;
m_pickerIndicatorIsVisible = true;
- ASSERT(pickerIndicatorElement());
+ DCHECK(pickerIndicatorElement());
pickerIndicatorElement()->removeInlineStyleProperty(CSSPropertyDisplay);
}

Powered by Google App Engine
This is Rietveld 408576698