third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp - Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/ColorInputType.cpp » ('j') | third_party/WebKit/Source/core/html/forms/FormController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp b/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

index f8ec7db7ce1a6d0afd33c1e513add41432f65e33..ef15af0dc557b23af7d39b7803ee8b1806831adf 100644

--- a/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

@@ -50,7 +50,7 @@ ChooserOnlyTemporalInputTypeView* ChooserOnlyTemporalInputTypeView::create(HTMLI

ChooserOnlyTemporalInputTypeView::~ChooserOnlyTemporalInputTypeView()

{

- ASSERT(!m_dateTimeChooser);

+ DCHECK(!m_dateTimeChooser);

}

DEFINE_TRACE(ChooserOnlyTemporalInputTypeView)

@@ -126,7 +126,7 @@ void ChooserOnlyTemporalInputTypeView::didChooseValue(const String& value)

void ChooserOnlyTemporalInputTypeView::didChooseValue(double value)

{

- ASSERT(std::isfinite(value) || std::isnan(value));

+ DCHECK(std::isfinite(value) || std::isnan(value));

if (std::isnan(value))

element().setValue(emptyString(), DispatchInputAndChangeEvent);

else